Skip to content

chore(x2a): align build:api-reports script with other workspaces#2354

Merged
eloycoto merged 1 commit intoredhat-developer:mainfrom
hopehadfield:fix-x2a-api-report
Feb 18, 2026
Merged

chore(x2a): align build:api-reports script with other workspaces#2354
eloycoto merged 1 commit intoredhat-developer:mainfrom
hopehadfield:fix-x2a-api-report

Conversation

@hopehadfield
Copy link
Member

@hopehadfield hopehadfield commented Feb 18, 2026

User description

Hey, I just made a Pull Request!

Hopefully this fixes the recent api report inconsistencies encountered with #2326 and #2331

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

PR Type

Enhancement


Description

  • Align x2a workspace build:api-reports script with other workspaces

  • Move TypeScript compilation flag to api-reports:only command

  • Fix api report generation inconsistencies from recent issues


Diagram Walkthrough

flowchart LR
  A["build:api-reports script"] -- "refactored to" --> B["build:api-reports:only --tsc"]
  C["yarn tsc && yarn build:api-reports:only"] -- "replaced by" --> B
  B -- "aligns with" --> D["other workspace patterns"]
Loading

File Walkthrough

Relevant files
Configuration changes
package.json
Refactor build:api-reports script command structure           

workspaces/x2a/package.json

  • Changed build:api-reports script from yarn tsc && yarn
    build:api-reports:only to yarn build:api-reports:only --tsc
  • Moves TypeScript compilation flag directly to the api-reports:only
    command
  • Aligns script structure with other workspaces in the repository
  • Fixes api report generation inconsistencies
+1/-1     

Signed-off-by: Hope Hadfield <hhadfiel@redhat.com>
@rhdh-qodo-merge
Copy link

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🎫 No ticket provided
  • Create ticket/issue
Codebase Duplication Compliance
🟢
No codebase code duplication found No new components were introduced in the PR code
Custom Compliance
🟢
Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@sonarqubecloud
Copy link

@rhdh-qodo-merge
Copy link

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
Possible issue
Forward flags to script correctly

In the build:api-reports script, add -- before the --tsc flag to ensure it's
passed correctly to the build:api-reports:only script and not interpreted by
yarn.

workspaces/x2a/package.json [13]

-"build:api-reports": "yarn build:api-reports:only --tsc",
+"build:api-reports": "yarn build:api-reports:only -- --tsc",
  • Apply / Chat
Suggestion importance[1-10]: 6

__

Why: The suggestion correctly identifies a potential ambiguity in how yarn handles arguments and proposes using -- to explicitly pass the --tsc flag to the script, which is a robust best practice.

Low
  • More

@eloycoto eloycoto merged commit 8f927ca into redhat-developer:main Feb 18, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants