fix(x2a): Fixing links in the artifacts path#2332
Merged
elai-shalev merged 4 commits intoredhat-developer:mainfrom Feb 16, 2026
Merged
fix(x2a): Fixing links in the artifacts path#2332elai-shalev merged 4 commits intoredhat-developer:mainfrom
elai-shalev merged 4 commits intoredhat-developer:mainfrom
Conversation
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
elai-shalev
approved these changes
Feb 16, 2026
| return `${targetRepoUrl}/blob/main/${value}`; | ||
| // Remove .git suffix if present (repos normalized for cloning have .git) | ||
| const baseUrl = targetRepoUrl.endsWith('.git') | ||
| ? targetRepoUrl.slice(0, -4) |
Contributor
There was a problem hiding this comment.
what about cases when the url provided is "https://github.com/org/repo.git/"
with a trailing slash it would be -5
Contributor
Author
There was a problem hiding this comment.
AFAIK, the endsWidth action only be executed if ends in .git
Contributor
There was a problem hiding this comment.
I mean, maybe we need to add
const baseUrl = targetRepoUrl.endsWith('.git/')
? targetRepoUrl.slice(0, -5)
as we don't control the targetRepoUrl
we should have stricter url encoding
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing the link on the Artifacts, because the link was not correct:
Now it's correct path, as: