-
-
Notifications
You must be signed in to change notification settings - Fork 439
[AutoImport] Handle FQCN in/not in use on auto import + remove unused import as prefix = suffix #7957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[AutoImport] Handle FQCN in/not in use on auto import + remove unused import as prefix = suffix #7957
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
3314d80
Add test case for issue with Carbon import
BinaryKitten 0a67e6a
fix fixture php line to enable clearer error showing
BinaryKitten 27b3869
Second example with Illuminate\Support\Carbon
BinaryKitten dc39e6c
rename test files after discussion
BinaryKitten 2efb395
move to tests
samsonasik 2475409
update fixture namespace
samsonasik 54f4fe1
[AutoImport] Handle FQCN in/not in use on auto import + remove unused…
samsonasik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| <?php | ||
|
|
||
| namespace Carbon; | ||
|
|
||
| if (interface_exists('Carbon\CarbonInterface')) { | ||
| return; | ||
| } | ||
|
|
||
| interface CarbonInterface | ||
| { | ||
|
|
||
| } |
49 changes: 49 additions & 0 deletions
49
tests/Issues/NamespacedUseAutoImport/Fixture/in_use_fqcn_docblock.php.inc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Rector\Tests\Issues\NamespacedUseAutoImport\Fixture; | ||
|
|
||
| use Carbon\Carbon; | ||
| use Carbon\CarbonInterface; | ||
|
|
||
| /** | ||
| * @property \Carbon\CarbonInterface|null $deleted_at | ||
| */ | ||
| class InUseFqcnDocblock | ||
| { | ||
| /** | ||
| * @return CarbonInterface[] | ||
| */ | ||
| public function demoFunction(): array | ||
| { | ||
| return [Carbon::parse('2026-01-01 11:16:01')]; | ||
| } | ||
| } | ||
|
|
||
| ?> | ||
| ----- | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Rector\Tests\Issues\NamespacedUseAutoImport\Fixture; | ||
|
|
||
| use Carbon\Carbon; | ||
| use Carbon\CarbonInterface; | ||
|
|
||
| /** | ||
| * @property CarbonInterface|null $deleted_at | ||
| */ | ||
| class InUseFqcnDocblock | ||
| { | ||
| /** | ||
| * @return CarbonInterface[] | ||
| */ | ||
| public function demoFunction(): array | ||
| { | ||
| return [Carbon::parse('2026-01-01 11:16:01')]; | ||
| } | ||
| } | ||
|
|
||
| ?> |
43 changes: 43 additions & 0 deletions
43
tests/Issues/NamespacedUseAutoImport/Fixture/not_in_use_fqcn_docblock.php.inc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Rector\Tests\Issues\NamespacedUseAutoImport\Fixture; | ||
|
|
||
| use Illuminate\Support\Carbon; | ||
| use Carbon\CarbonInterface; | ||
|
|
||
| /** | ||
| * @property \Carbon\CarbonInterface|null $deleted_at | ||
| */ | ||
| class NotInUseFqcnDocblock | ||
| { | ||
| public function demoFunction(): array | ||
| { | ||
| return [Carbon::parse('2026-01-01 11:16:01')]; | ||
| } | ||
| } | ||
|
|
||
| ?> | ||
| ----- | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Rector\Tests\Issues\NamespacedUseAutoImport\Fixture; | ||
|
|
||
| use Illuminate\Support\Carbon; | ||
| use Carbon\CarbonInterface; | ||
|
|
||
| /** | ||
| * @property CarbonInterface|null $deleted_at | ||
| */ | ||
| class NotInUseFqcnDocblock | ||
| { | ||
| public function demoFunction(): array | ||
| { | ||
| return [Carbon::parse('2026-01-01 11:16:01')]; | ||
| } | ||
| } | ||
|
|
||
| ?> |
42 changes: 42 additions & 0 deletions
42
tests/Issues/NamespacedUseAutoImport/Fixture/not_in_use_fqcn_docblock_2.inc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Rector\Tests\Issues\NamespacedUseAutoImport\Fixture; | ||
|
|
||
| use Carbon\Carbon; | ||
| use Carbon\CarbonInterface; | ||
|
|
||
| /** | ||
| * @property \Carbon\CarbonInterface|null $deleted_at | ||
| */ | ||
| class NotInUseFqcnDocblock2 | ||
| { | ||
| public function demoFunction(): array | ||
| { | ||
| return [Carbon::parse('2026-01-01 11:16:01')]; | ||
| } | ||
| } | ||
|
|
||
| ?> | ||
| ----- | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Rector\Tests\Issues\NamespacedUseAutoImport\Fixture; | ||
|
|
||
| use Carbon\Carbon; | ||
|
|
||
| /** | ||
| * @property CarbonInterface|null $deleted_at | ||
| */ | ||
| class NotInUseFqcnDocblock2 | ||
| { | ||
| public function demoFunction(): array | ||
| { | ||
| return [Carbon::parse('2026-01-01 11:16:01')]; | ||
| } | ||
| } | ||
|
|
||
| ?> | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, missing
.php.incThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ref PR:
with also update expected output :)