Rewrite TmdbProvider to remove external lib dependency#2800
Open
Luna712 wants to merge 1 commit into
Open
Conversation
As a side-effect, this also removes all gson usage from extractors and uses AppUtils methods, because gson was only an implicit dependency from the external tmdb library.
Luna712
commented
May 18, 2026
| // Fuck it, public private api key because github actions won't co-operate. | ||
| // Please no stealy. | ||
| private val tmdb = Tmdb("e6333b32409e02a4a6eba6fb7ff866bb") | ||
| private val tmdbApiKey = "e6333b32409e02a4a6eba6fb7ff866bb" |
Contributor
Author
There was a problem hiding this comment.
This should work in GH actions as a secret now as well (done just like MDL). We should probably move it there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a side-effect, this also removes all gson usage from extractors and uses AppUtils methods, because gson was only an implicit dependency from the external tmdb library.