Skip to content

Conversation

@KyoungWan
Copy link

Description

Introduces noir-circuit to the zk-symmetric-crypto.
Normaly in noir, Barrebenberg is used as backend and barretenberg uses the UltraHonk proving scheme from Aztec Protocol.

Testing (ignore for documentation update)

cd js
npm run test lib.test.ts

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Key changes:

  • Introduce BarretenbergOperator type with ultrahonkProve/ultrahonkVerify methods (instead of groth16)
  • Add makeBarretenbergZKOperator function that creates a ZK operator
    using Noir circuits and Aztec's bb.js
  • Added type guards and updated proof generation/verification logic to
    support both Groth16 and UltraHonk schemes
  • Supports AES-128-CTR with AES-256-CTR circuit.

Checklist:

Additional Notes:

@CLAassistant
Copy link

CLAassistant commented Jul 22, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 3 committers have signed the CLA.

❌ KyoungWan
❌ qpzm
❌ 0xKarl98
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai
Copy link

coderabbitai bot commented Jul 22, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

0xKarl98 and others added 7 commits July 25, 2025 17:13
- Added comprehensive benchmark section with performance metrics
- Included test commands for all ZK proof systems
- Documented ChaCha20 Noir circuit performance comparison
- Added detailed test environment specifications
Add benchmark for chach20 under gnark
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants