Work around broken composer install for legacy PHP on Windows#306
Merged
WyriHaximus merged 1 commit intoreactphp:1.xfrom Jun 6, 2023
Merged
Work around broken composer install for legacy PHP on Windows#306WyriHaximus merged 1 commit intoreactphp:1.xfrom
WyriHaximus merged 1 commit intoreactphp:1.xfrom
Conversation
SimonFrings
approved these changes
Jun 6, 2023
WyriHaximus
approved these changes
Jun 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset applies a lovely work-around for the broken composer install on legacy PHP on Windows. We've seen broken composer installs on such legacy platforms for the better half of the day and we've already wasted too much time on legacy platforms, so disabling HTTPS here seems reasonable. Note that this will likely be removed as part of upcoming ReactPHP v3 as discussed in https://github.com/orgs/reactphp/discussions/481 or in case the legacy platforms start working again, whichever comes first.
Refs #305 and composer/composer#5436
Builds on top of #299 and #238