Drop deprecated Factory, use Loop instead#274
Merged
SimonFrings merged 1 commit intoreactphp:3.xfrom Feb 6, 2024
Merged
Conversation
SimonFrings
approved these changes
Feb 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simple changeset drops the deprecated
Factoryclass from this package. As ofv1.2.0, we recommend using theLoopclass instead, so upgrading should be straightforward for most use cases:The existing factory logic has been refactored slightly and has been moved into the existing
Loop. I've tried to keep changes to a minimum, so this does not otherwise affect the publicLoopAPI. This PR also builds on top of recent PR #273 that dropped some of the legacy loop implementations.The original deprecation message has been in place for a couple of years already, so this PR builds on top of #226, #229 and #231.