Skip to content

fix(a11y): add aria-label to icon-only Sandpack toolbar links #8395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seojcarlos wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

fix(a11y): add aria-label to icon-only Sandpack toolbar links #8395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/MDX/Sandpack/OpenInCodeSandboxButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ export const OpenInCodeSandboxButton = () => {
return (
<UnstyledOpenInCodeSandboxButton
className="text-sm text-primary dark:text-primary-dark inline-flex items-center hover:text-link duration-100 ease-in transition mx-1 ms-2 md:ms-1"
title="Open in CodeSandbox">
title="Open in CodeSandbox"
aria-label="Open in CodeSandbox">
<IconNewPage
className="inline mx-1 relative top-[1px]"
width="1em"
Expand Down
1 change: 1 addition & 0 deletions src/components/MDX/Sandpack/OpenInTypeScriptPlayground.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ export const OpenInTypeScriptPlaygroundButton = (props: {content: string}) => {
contentWithReactImport
)}`}
title="Open in TypeScript Playground"
aria-label="Open in TypeScript Playground"
target="_blank"
rel="noreferrer">
<IconNewPage
Expand Down
Loading