Feature: Cancellation support for TransformAsync#1135
Open
glen-nicol wants to merge 1 commit into
Open
Conversation
1b19eb0 to
49eae8f
Compare
JakenVeina
requested changes
Jul 13, 2026
JakenVeina
left a comment
Collaborator
There was a problem hiding this comment.
Looks alright. Not sure if I completely follow all the exception logic in the List version, but I suppose it makes sense to swallow exceptions related to cancellation. Kinda makes me think Observable.FromAsync() ought to be the one doing that.
I do need to see some tests added for new functionality, though, even if they're mostly performative. If you can add some, great, otherwise I'll get around to it eventually, assuming I've got write access to your branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following this discussion I decided to revert back to just an additional overload of TransformAsync instead of using TransferAsyncCancel. I removed the ambiguous overload.
I decided it was best to extend the existing pattern of using the overload with the most parameters and modified existing operators to use the new overload that has the cancellation token parameter and just discarded that argument for the overloads with fewer parameters.
I added support to the List variant too and modified the internals on that one to avoid a cancelation of one from releasing the async lock of another in the same stream.