Fix render callback start/stop race in C++ NativeAnimated#57270
Open
bartlomiejbloniarz wants to merge 1 commit into
Open
Fix render callback start/stop race in C++ NativeAnimated#57270bartlomiejbloniarz wants to merge 1 commit into
bartlomiejbloniarz wants to merge 1 commit into
Conversation
Summary: The C++ NativeAnimated manager coordinated its render-callback start/stop through an atomic flag, but registered/unregistered the callback and tracked its id outside that atomic. When start (JS thread) and stop (UI thread) ran concurrently, a stop could act on a stale id and miss the just-registered callback, leaving it orphaned. Orphaned callbacks are never removed and run on every frame, accumulating over time. Coordinate the shared animation backend path through a single atomic callback id (0 means "not started"): start registers then publishes the id with a compare-exchange, undoing the registration if it lost the race; stop atomically takes the id and stops exactly that callback. Reserve backend callback id 0 so it can serve as the sentinel. Changelog: [General][Fixed] - Fix a race in the C++ Animated render-callback lifecycle that could leave stale callbacks running on every frame Differential Revision: D109009181
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@bartlomiejbloniarz has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109009181. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The C++ NativeAnimated manager coordinated its render-callback start/stop
through an atomic flag, but registered/unregistered the callback and tracked its
id outside that atomic. When start (JS thread) and stop (UI thread) ran
concurrently, a stop could act on a stale id and miss the just-registered
callback, leaving it orphaned. Orphaned callbacks are never removed and run on
every frame, accumulating over time.
Coordinate the shared animation backend path through a single atomic callback id
(0 means "not started"): start registers then publishes the id with a
compare-exchange, undoing the registration if it lost the race; stop atomically
takes the id and stops exactly that callback. Reserve backend callback id 0 so
it can serve as the sentinel.
Changelog: [General][Fixed] - Fix a race in the C++ Animated render-callback lifecycle that could leave stale callbacks running on every frame
Differential Revision: D109009181