Remove deprecated Instance type aliases (Flow) (#57229)#57229
Closed
huntie wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@huntie has exported this pull request. If you are a Meta employee, you can view the originating Diff in D107268481. |
Summary: Pull Request resolved: react#57229 Remove the deprecated `PublicScrollViewInstance` and `PublicModalInstance` type aliases, replacing all remaining usages with the canonical `ScrollViewInstance` and `ModalInstance` types. NOTE: Existing equivalent types are **left alone** in the manual `.d.ts` sources (current TS API), as this is covered by the existing breaking migration notes for ref types under the Strict API. **Changes** - Delete `PublicScrollViewInstance` alias (ScrollView.js) - Delete `PublicModalInstance` alias (Modal.js) - Update `IntersectionObserverExplicitRootScroll.js` rn-tester example Changelog: [General][Removed] - **Strict TypeScript API**: Remove deprecated `PublicScrollViewInstance` and `PublicModalInstance` types. Use `ScrollViewInstance` and `ModalInstance` instead. Reviewed By: cipolleschi Differential Revision: D107268481
meta-codesync
Bot
changed the title
huntie
force-pushed
the
export-D107268481
branch
from
d49dc85 to
6088128
Compare
|
This pull request has been merged in 74fdfd1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Remove the deprecated
PublicScrollViewInstanceandPublicModalInstancetype aliases, replacing all remaining usages with the canonicalScrollViewInstanceandModalInstancetypes.NOTE: Existing equivalent types are left alone in the manual
.d.tssources (current TS API), as this is covered by the existing breaking migration notes for ref types under the Strict API.Changes
PublicScrollViewInstancealias (ScrollView.js)PublicModalInstancealias (Modal.js)IntersectionObserverExplicitRootScroll.jsrn-tester exampleChangelog:
[General][Removed] - Strict TypeScript API: Remove deprecated
PublicScrollViewInstanceandPublicModalInstancetypes. UseScrollViewInstanceandModalInstanceinstead.Reviewed By: cipolleschi
Differential Revision: D107268481