Document formSheet props and limitiations#1402
Merged
satya164 merged 7 commits intoreact-navigation:mainfrom Mar 9, 2025
Merged
Document formSheet props and limitiations#1402satya164 merged 7 commits intoreact-navigation:mainfrom
satya164 merged 7 commits intoreact-navigation:mainfrom
Conversation
✅ Deploy Preview for react-navigation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
Author
kkafar
reviewed
Feb 20, 2025
Contributor
kkafar
left a comment
kkafar
left a comment
There was a problem hiding this comment.
Okay,
we still need to record the examples. I'll read through text once we got this ready.
Co-authored-by: Kacper Kafara <kacperkafara@gmail.com>
Co-authored-by: Kacper Kafara <kacperkafara@gmail.com>
kkafar
approved these changes
Feb 25, 2025
Contributor
kkafar
left a comment
kkafar
left a comment
There was a problem hiding this comment.
Looks good! There are a lot of assets, but we should be fine.
However before merging we need to improve PR description.
Contributor
Author
|
PR description updated. |
satya164
approved these changes
Mar 2, 2025
Member
satya164
left a comment
satya164
left a comment
There was a problem hiding this comment.
Thanks for the PR.
One thing I'd like to see for bottom sheet is a fully runnable example on snack so devs can test it out directly. You can copy one of the other examples on this page and tweak it to add bottom sheet.
satya164
pushed a commit
to shubh73/react-navigation.github.io
that referenced
this pull request
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added details about formSheet - props, examples.
Changes
presentation: 'formSheet'description to specify correct behavior on Android,presentation: 'formSheet'to showcase different detents and include both Android and iOS,formSheeton Android,formSheet: