Bug fix/cross button #104
Open
piyushdevOP wants to merge 12 commits intoreact-native-elements:masterfrom
Open
Conversation
|
Deploy preview for rne-playground ready! Built with commit a334386 |
Author
|
Issue #70 crossButtonIssue.movFixed #104 crossButtonFixed.mov@ARJUN-SABU @ankushdutt @pranshuchittora @Uyadav207 Please look into it. This PR fixes issue #70 . |
package.json
Outdated
| "react-scripts": "3.4.1", | ||
| "react-view": "^2.3.2" | ||
| "react-view": "^2.3.2", | ||
| "v8": "^0.1.0" |
public/index.html
Outdated
| <meta property="og:type" content="website" /> | ||
| <meta property="og:url" content="https://react-native-elements.js.org/" /> | ||
| <meta property="og:title" content="Playground 🚀 | React Native Elements" /> | ||
| <meta property="og:title" content="Playground | React Native Elements" /> |
Author
There was a problem hiding this comment.
Hey Pranshu , I will undo this right away.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug Fix
Did you add tests for your changes?
No.
If relevant, did you update the documentation?
Not Required
Summary
This PR fixes the crossButton bug in Input page. The cross button now clears the input text.
Fixes Issue #70
Does this PR introduce a breaking change?
Not Applicable
Other information