Skip to content

Add nkf gem for Ruby 3.4 compatibility#215

Open
cipolleschi wants to merge 1 commit into
0.81-stablefrom
fix/add-nkf-gem-ruby34
Open

Add nkf gem for Ruby 3.4 compatibility#215
cipolleschi wants to merge 1 commit into
0.81-stablefrom
fix/add-nkf-gem-ruby34

Conversation

@cipolleschi
Copy link
Copy Markdown
Contributor

Summary

  • Ruby 3.4 removed kconv from the standard library
  • The xcodeproj gem (used by CocoaPods) depends on kconv, which is now provided by the nkf gem
  • Without this, bundle exec pod install fails with LoadError - cannot load such file -- kconv

Test plan

  • Created a new RN 0.81 app with Ruby 3.4.2
  • Verified bundle exec pod install fails without this change
  • Added gem 'nkf' to the Gemfile
  • Ran bundle install and bundle exec pod install successfully

Ruby 3.4 removed `kconv` from the standard library. The `xcodeproj` gem
(used by CocoaPods) depends on `kconv`, which is now provided by the
`nkf` gem. Without it, `bundle exec pod install` fails with:

  LoadError - cannot load such file -- kconv
@cortinico
Copy link
Copy Markdown
Member

@cipolleschi do we need this only for 0.81?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants