Claude/resolve pr feedback esy0d#2794
Closed
matthargett wants to merge 10 commits intoreact-native-community:mainfrom
Closed
Claude/resolve pr feedback esy0d#2794matthargett wants to merge 10 commits intoreact-native-community:mainfrom
matthargett wants to merge 10 commits intoreact-native-community:mainfrom
Conversation
… 'dom' types not being present, I'm not sure why this works on other platforms
…) working differently, we have to loosen one lint rule that won't work due to to way typescript-eslint walks symbolic links in a non-agnostic way. building and resolution still seems to work properly.
…m shell support, and 2) fixes some critical holes that can lead to remote code execution. nice side effect, the new types pointed out a typo (utf-8 instead of utf8 for a param).
… explicit help to propertly root the test discovery
…mock getEnvironmentInfo(), which is necessary on Windows and makes the test run LOT faster.
…perating systems and filesystems (eg on linux/bsd).
…-fix the build. powershell emits an extra CR after process terminates, so trim() the stderr output to make the snapshot fulfill its intent in an OS-agnostic way
…stem combinations. it looks like there's a latent race in e2e tests where sometimes a directory doesn't exist yet, or was already removed. this isn't a new issue, so check for directory before removal. trim stdout/stderr in the test helpers, not just in one test.
matthargett
requested review from
cipolleschi,
cortinico and
thymikee
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
Checklist
react-nativecheckout (instructions).