Skip to content

fix: keep header nav links ahead of utility icons in tab order#1199

Open
hiromieguchi802-lab wants to merge 1 commit intoreact-hook-form:masterfrom
hiromieguchi802-lab:fix/nav-focus-order
Open

fix: keep header nav links ahead of utility icons in tab order#1199
hiromieguchi802-lab wants to merge 1 commit intoreact-hook-form:masterfrom
hiromieguchi802-lab:fix/nav-focus-order

Conversation

@hiromieguchi802-lab
Copy link
Contributor

Fixes #1182

Summary

  • move the primary navigation markup ahead of the search and social utility links in the DOM
  • keep the existing visual layout unchanged by relying on the current absolute positioning styles
  • preserve the existing nav/search/toggle behavior while improving keyboard focus order for header navigation

Verification

  • confirmed the issue points to src/components/Nav.tsx and that the header utility links were rendered before the main nav links in the DOM
  • confirmed this change is limited to reordering the existing Nav JSX blocks with no link or style logic changes
  • attempted local dependency installation to run site checks, but the workspace is still mid-install and the repo currently cannot run
    ext lint/ sc to completion in this environment yet

@vercel
Copy link
Contributor

vercel bot commented Mar 24, 2026

@hiromieguchi802-lab is attempting to deploy a commit to the BEEKAI OSS Team on Vercel.

A member of the Team first needs to authorize it.

@netlify
Copy link

netlify bot commented Mar 24, 2026

Deploy Preview for sage-cassata-31d224 ready!

Name Link
🔨 Latest commit 9f7059a
🔍 Latest deploy log https://app.netlify.com/projects/sage-cassata-31d224/deploys/69c259f92a4f1a0008051860
😎 Deploy Preview https://deploy-preview-1199--sage-cassata-31d224.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hiromieguchi802-lab
Copy link
Contributor Author

Heads-up: this PR only reorders the existing header blocks in \src/components/Nav.tsx\ to put the primary nav before utility links in the DOM. I checked the failing format job and it is currently reporting \src/content/docs/useform.mdx, which is outside this change set. If you'd prefer, I can re-run or help narrow that down further.

@bluebill1049
Copy link
Member

thanks! could you share a screenshot the diff?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

issue: [a11y] Header navigation has incorrect keyboard focus order (icons are focused before main nav items)

2 participants