Fix: bound='parent' with SVG#594
Closed
WTomoharu wants to merge 1 commit intoreact-grid-layout:masterfrom
Closed
Conversation
Collaborator
|
Closing this PR as stale. This PR fixing SVG bounds has been open since 2021 without being merged. If SVG bounds='parent' is still an issue, please open a fresh PR against the current codebase. Thank you for the contribution! |
Collaborator
|
Reopening - this is an important fix for SVG bounds support. |
STRML
added a commit
that referenced
this pull request
Dec 31, 2025
- Use getBoundingClientRect() as fallback for SVG elements which lack clientWidth/clientHeight properties - Calculate SVG element offsets using bounding rectangles since they don't have offsetLeft/offsetTop - Accept Element (not just HTMLElement) for bounds container to support SVG parent elements - HTMLElements still use the fast path (clientWidth/clientHeight) Fixes #213 Closes #594
3 tasks
Collaborator
|
Implemented in #789 with improvements: uses clientWidth/clientHeight for HTMLElements (fast path) and falls back to getBoundingClientRect only for SVG elements. Also fixed a bug in the original PR where paddingLeft was used for top offset calculation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #213 by support for bound='parent' with SVG.
Closes: #213