Skip to content

fix: open dropdown on spacekey for keyboard accessibility #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zombieJ merged 2 commits into from
Feb 5, 2026
+27 −3
Merged

fix: open dropdown on spacekey for keyboard accessibility #1200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3643555
fix: open dropdown on spacekey for keyboard accessibility
claytonlin1110 Feb 3, 2026
6be9f0d
fix: add test
claytonlin1110 Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/BaseSelect/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,9 +463,11 @@ const BaseSelect = React.forwardRef<BaseSelectRef, BaseSelectProps>((props, ref)
const { key } = event;

const isEnterKey = key === 'Enter';
const isSpaceKey = key === ' ';

if (isEnterKey) {
// Do not submit form when type in the input
// Enter or Space opens dropdown (ARIA combobox: spacebar should open)
if (isEnterKey || isSpaceKey) {
// Do not submit form when type in the input; prevent Space from scrolling page
if (mode !== 'combobox') {
event.preventDefault();
}
Expand Down Expand Up @@ -507,7 +509,7 @@ const BaseSelect = React.forwardRef<BaseSelectRef, BaseSelectProps>((props, ref)
}
}

if (mergedOpen && (!isEnterKey || !keyLockRef.current)) {
if (mergedOpen && (!isEnterKey || !keyLockRef.current) && !isSpaceKey) {
// Lock the Enter key after it is pressed to avoid repeated triggering of the onChange event.
if (isEnterKey) {
keyLockRef.current = true;
Expand Down
22 changes: 22 additions & 0 deletions tests/Accessibility.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,28 @@ describe('Select.Accessibility', () => {
expect(container.querySelector('input')!.getAttribute('aria-label')).toEqual('light');
});

// https://github.com/ant-design/ant-design/issues/56841
it('spacebar opens dropdown (ARIA combobox)', () => {
const { container } = render(
<Select
options={[
{ label: 'Bamboo', value: 'bamboo' },
{ label: 'Light', value: 'light' },
]}
/>,
);

const selector = container.querySelector('.rc-select') as HTMLElement;
expectOpen(container, false);

fireEvent.focus(container.querySelector('input')!);
keyDown(selector, 32, { key: ' ' });
act(() => {
jest.runAllTimers();
});
expectOpen(container);
});

// https://github.com/ant-design/ant-design/issues/31850
it('active index should keep', async () => {
const onActive = jest.fn();
Expand Down
Loading