protondrive: align move crypto and revision fallback with the SDK#4
Open
tdawe1 wants to merge 3 commits intorclone:masterfrom
Open
protondrive: align move crypto and revision fallback with the SDK#4tdawe1 wants to merge 3 commits intorclone:masterfrom
tdawe1 wants to merge 3 commits intorclone:masterfrom
Conversation
Update the bridge to match SDK-era ProtonDrive request shapes and request headers while keeping mixed-version compatibility. This removes the duplicate outer upload retry loop, centralizes manager retry configuration, improves draft-conflict recovery, and adds focused tests for compatibility, upload delegation, and manager retry behavior.
Preserve passphrase session keys during moves and only send optional move signatures when the SDK would. Also tolerate missing revision-verification helpers so the bridge can follow the supported v2 path without reviving deprecated API behavior.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support the rclone Proton Drive backend update by aligning the bridge move/upload compatibility behavior with the current Proton Drive SDK.
The main issue here was that move-related flows no longer matched the newer SDK behavior closely enough. In practice, that meant moves could fail or leave moved folders containing files in a bad state.
This change updates the bridge to:
Testing:
This PR should be reviewed on top of the companion
go-proton-apiSDK base compatibility PR.Companion SDK base PR: rclone/go-proton-api#5