-
Notifications
You must be signed in to change notification settings - Fork 13
fix(#736): updates for doc issues found in apsara audit #756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Shreyag02
wants to merge
10
commits into
main
Choose a base branch
from
fix/doc_issues_from_apsara_audit
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
01eeb11
fix(#736): linting issues
Shreyag02 b44def4
fix: comment resolutions
Shreyag02 0411367
fix: spacing and padding issues in docs preview
Shreyag02 127241c
Merge branch 'main' into fix/doc_issues_from_apsara_audit
Shreyag02 87bc3c8
fix: virtualized and non virtualized demo update in datatable
Shreyag02 962b26a
fix: added an updated doc for interactive chips in input field sample
Shreyag02 a39324b
resolving conflicts
Shreyag02 6653c78
Merge branch 'main' into fix/doc_issues_from_apsara_audit
Shreyag02 ad8b48f
fix: updated the base ui format input value conversion
Shreyag02 d3f4947
fix: reverted changes in search component
Shreyag02 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import { Flex, Separator, Text } from '@raystack/apsara'; | ||
|
|
||
| export default function NotFound() { | ||
| return ( | ||
| <Flex | ||
| align='center' | ||
| justify='center' | ||
| gap='large' | ||
| width='full' | ||
| style={{ height: '100vh' }} | ||
| > | ||
| <Text size={10} weight='bold'> | ||
| 404 | ||
| </Text> | ||
| <Separator orientation='vertical' style={{ height: '48px' }} /> | ||
| <Text size={7}>This page could not be found.</Text> | ||
| </Flex> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| import { InputField } from '@raystack/apsara'; | ||
| import { useState } from 'react'; | ||
|
|
||
| export default function ChipInputDemo() { | ||
| const [chips, setChips] = useState([ | ||
| { label: 'Tag1' }, | ||
| { label: 'Tag2' }, | ||
| { label: 'Tag3' }, | ||
| { label: 'Tag4' }, | ||
| { label: 'Tag5' } | ||
| ]); | ||
| const [input, setInput] = useState(''); | ||
|
|
||
| return ( | ||
| <InputField | ||
| placeholder='Type and press Enter...' | ||
| width='560px' | ||
| value={input} | ||
| onChange={e => setInput(e.target.value)} | ||
| onKeyDown={e => { | ||
| if (e.key === 'Enter' && input.trim()) { | ||
| setChips(prev => [...prev, { label: input.trim() }]); | ||
| setInput(''); | ||
| } | ||
| }} | ||
| chips={chips.map((c, i) => ({ | ||
| label: c.label, | ||
| onRemove: () => setChips(prev => prev.filter((_, j) => j !== i)) | ||
| }))} | ||
| maxChipsVisible={4} | ||
| /> | ||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,10 @@ | ||
| .preview { | ||
| padding: 0; | ||
| padding: var(--rs-space-10); | ||
| width: 100%; | ||
| height: 100%; | ||
| height: stretch; | ||
| flex: 1; | ||
| display: flex; | ||
| justify-content: center; | ||
| align-items: center; | ||
| overflow: auto; | ||
| } | ||
| overflow: visible; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.