Skip to content

refactor: standardize disabled state and cursor: default #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paanSinghCoder merged 3 commits into from
Apr 7, 2026
Merged

refactor: standardize disabled state and cursor: default #728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7545f2f
refactor: standardize-disabled-state
paanSinghCoder Apr 2, 2026
8609e99
refactor: remove cursor:pointer and add disabled states
paanSinghCoder Apr 2, 2026
4ae1f92
Merge branch 'main' into refactor/standardize-disabled-state
paanSinghCoder Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/raystack/components/breadcrumb/breadcrumb.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,7 @@
}

.breadcrumb-link-disabled {
color: var(--rs-color-foreground-base-tertiary);
opacity: 0.5;
cursor: not-allowed;
pointer-events: none;
}

Expand Down Expand Up @@ -106,4 +104,4 @@
.breadcrumb-dropdown-item:hover {
background-color: var(--rs-color-background-base-primary-hover);
border-radius: var(--rs-radius-2);
}
}
9 changes: 1 addition & 8 deletions packages/raystack/components/button/button.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
.button:disabled,
.button-disabled {
opacity: 0.5;
cursor: not-allowed;
pointer-events: initial;
}

Expand Down Expand Up @@ -104,7 +103,7 @@
.button-outline.button-disabled {
opacity: 0.5;
background-color: transparent;
cursor: not-allowed;
cursor: default;
}

.button-outline:disabled:hover,
Expand All @@ -127,7 +126,6 @@
background-color: transparent;
color: var(--rs-color-foreground-accent-primary);
border-color: var(--rs-color-border-accent-primary);
cursor: not-allowed;
}

.button-outline-accent.button-loading:hover {
Expand Down Expand Up @@ -170,7 +168,6 @@
.button-ghost:disabled,
.button-ghost.button-disabled {
opacity: 0.5;
Copy link
Copy Markdown
Member

@rsbh rsbh Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets have a css variable for opacity as well

cursor: not-allowed;
}

.button-ghost:disabled:hover,
Expand All @@ -192,7 +189,6 @@
.button-ghost.button-loading[data-radix-dropdown-menu-trigger][data-state="open"] {
background-color: transparent;
border-color: var(--rs-color-border-base-primary);
cursor: not-allowed;
}

.button-text {
Expand All @@ -210,15 +206,13 @@
.button-text:disabled,
.button-text.button-disabled {
opacity: 0.5;
cursor: not-allowed;
}

.button-text.button-loading:hover,
.button-text.button-loading:active,
.button-text.button-loading[data-radix-popover-trigger][data-state="open"],
.button-text.button-loading[data-radix-dropdown-menu-trigger][data-state="open"] {
background-color: transparent;
cursor: not-allowed;
}

.button-text:disabled:hover,
Expand All @@ -243,7 +237,6 @@
.button-loading[data-radix-popover-trigger][data-state="open"],
.button-loading[data-radix-dropdown-menu-trigger][data-state="open"] {
background-color: inherit;
cursor: not-allowed;
}

.loader {
Expand Down
3 changes: 1 addition & 2 deletions packages/raystack/components/calendar/calendar.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,8 +198,7 @@
}

.disabled {
color: var(--rs-color-foreground-base-tertiary);
opacity: 0.8;
opacity: 0.5;
}

.day.today button::after {
Expand Down
1 change: 0 additions & 1 deletion packages/raystack/components/checkbox/checkbox.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@

.checkbox[data-disabled] {
opacity: 0.5;
cursor: not-allowed;
}

.checkbox[data-disabled]:hover {
Expand Down
2 changes: 1 addition & 1 deletion packages/raystack/components/combobox/combobox.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
}

.menuitem[data-disabled] {
opacity: 0.6;
opacity: 0.5;
pointer-events: none;
}

Expand Down
3 changes: 1 addition & 2 deletions packages/raystack/components/icon-button/icon-button.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,8 @@
}

.iconButton:disabled {
cursor: not-allowed;
opacity: 0.5;
color: var(--rs-color-foreground-base-secondary);
cursor: default;
}

.iconButton:active:not(:disabled) {
Expand Down
8 changes: 2 additions & 6 deletions packages/raystack/components/input-field/input-field.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,7 @@
}

.input-disabled-wrapper {
background: var(--rs-color-background-base-primary);
border-color: var(--rs-color-border-base-tertiary);
opacity: 0.4;
cursor: not-allowed;
opacity: 0.5;
}

.leading-icon {
Expand Down Expand Up @@ -121,7 +118,6 @@

.input-disabled {
color: var(--rs-color-foreground-base-tertiary);
cursor: not-allowed;
}

.helper-text {
Expand Down Expand Up @@ -310,4 +306,4 @@
.input-error-wrapper.variant-borderless:hover,
.input-error-wrapper.variant-borderless:focus-within {
border-color: transparent;
}
}
2 changes: 1 addition & 1 deletion packages/raystack/components/menu/cell.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
}

.cell[aria-disabled] {
opacity: 0.6;
opacity: 0.5;
pointer-events: none;
}

Expand Down
3 changes: 1 addition & 2 deletions packages/raystack/components/radio/radio.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
.radioitem[data-disabled]:hover {
background: var(--rs-color-background-neutral-secondary);
border-color: var(--rs-color-border-base-secondary);
cursor: not-allowed;
}

.radioitem[data-disabled][data-checked],
Expand Down Expand Up @@ -67,4 +66,4 @@

.radioitem[data-disabled] .indicator::after {
background: var(--rs-color-foreground-base-emphasis);
}
}
1 change: 0 additions & 1 deletion packages/raystack/components/search/search.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
}

.clearButton:disabled {
cursor: not-allowed;
opacity: 0.5;
}

Expand Down
43 changes: 9 additions & 34 deletions packages/raystack/components/select/select.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
} */

.menuitem[data-disabled] {
opacity: 0.6;
opacity: 0.5;
pointer-events: none;
}

Expand Down Expand Up @@ -117,16 +117,18 @@
letter-spacing: var(--rs-letter-spacing-small);
gap: var(--rs-space-2);
}

.trigger[data-multiselectable="true"] {
padding-top: var(--rs-space-2);
padding-bottom: var(--rs-space-2);
}

.trigger:hover {
.trigger:hover:not([data-disabled]):not(:disabled) {
cursor: pointer;
background-color: var(--rs-color-background-base-primary-hover);
color: var(--rs-color-foreground-base-primary);
}

.trigger:focus-visible {
outline: 1px solid var(--rs-color-border-accent-emphasis);
}
Expand All @@ -136,7 +138,7 @@
}

.trigger:disabled {
opacity: 0.6;
opacity: 0.5;
pointer-events: none;
}

Expand Down Expand Up @@ -226,34 +228,7 @@
}

.trigger[data-disabled] {
background: var(--rs-color-background-base-primary);
border-color: var(--rs-color-border-base-tertiary);
opacity: 0.4;
cursor: not-allowed !important;
pointer-events: none;
}

.trigger[data-disabled]:hover {
background: var(--rs-color-background-base-primary);
border-color: var(--rs-color-border-base-tertiary);
cursor: not-allowed !important;
}

.trigger[data-disabled] .triggerContent {
color: var(--rs-color-foreground-base-tertiary);
}

.trigger[data-disabled] .triggerIcon {
color: var(--rs-color-foreground-base-tertiary);
}

.trigger[data-disabled] .placeholder,
.trigger[data-disabled] [data-placeholder] {
color: var(--rs-color-foreground-base-tertiary);
}

[data-disabled] {
cursor: not-allowed;
opacity: 0.5;
pointer-events: none;
}

Expand All @@ -271,9 +246,9 @@
.comboboxContent:not(:has(.menuitem:not([data-hidden="true"]))) {
padding: 0;
}

.content:has(.comboboxContent:empty) .comboboxInput,
.content:has(.comboboxContent:not(:has(.menuitem:not([data-hidden="true"]))))
.comboboxInput {
.content:has(.comboboxContent:not(:has(.menuitem:not([data-hidden="true"])))) .comboboxInput {
border-bottom: none;
}

Expand All @@ -300,4 +275,4 @@

.hidden {
display: none;
}
}
6 changes: 3 additions & 3 deletions packages/raystack/components/sidebar/sidebar.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,7 @@
}

.nav-item[data-disabled="true"] {
opacity: 0.6;
cursor: not-allowed;
opacity: 0.5;
pointer-events: none;
}

Expand Down Expand Up @@ -205,10 +204,11 @@
}

@media (prefers-reduced-motion: reduce) {

.root,
.nav-item,
.nav-text,
.resizeHandle {
transition: none;
}
}
}
1 change: 0 additions & 1 deletion packages/raystack/components/switch/switch.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
}

.switch[data-disabled] {
cursor: not-allowed;
background: var(--rs-color-background-neutral-primary);
}

Expand Down
4 changes: 1 addition & 3 deletions packages/raystack/components/tabs/tabs.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,6 @@

.trigger[data-disabled] {
opacity: 0.5;
cursor: not-allowed;
color: var(--rs-color-foreground-base-secondary);
pointer-events: none;
}

Expand Down Expand Up @@ -102,4 +100,4 @@ asked the OS/browser for less or no motion
/* Base UI uses hidden attribute for inactive panels */
.content[hidden] {
display: none;
}
}
22 changes: 11 additions & 11 deletions packages/raystack/components/text-area/text-area.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@
letter-spacing: var(--rs-letter-spacing-mini);
}

.labelDisabled {
opacity: 0.5;
}

.helpIcon {
color: var(--rs-color-foreground-base-secondary);
display: flex;
Expand Down Expand Up @@ -66,12 +70,12 @@
overflow: hidden;
}

.textarea:hover {
.textarea:hover:not(:disabled) {
border-color: var(--rs-color-border-base-focus);
background: var(--rs-color-background-base-primary-hover);
}

.textarea:focus {
.textarea:focus:not(:disabled) {
border-color: var(--rs-color-border-accent-emphasis);
background: var(--rs-color-background-base-primary);
outline: none;
Expand All @@ -85,11 +89,7 @@
}

.textarea:disabled {
background: var(--rs-color-background-base-primary);
border-color: var(--rs-color-border-base-tertiary);
color: var(--rs-color-foreground-base-tertiary);
cursor: not-allowed;
opacity: 0.4;
opacity: 0.5;
}

.textarea:read-only {
Expand All @@ -100,11 +100,11 @@
border-color: var(--rs-color-border-danger-primary);
}

.error:hover {
.error:hover:not(:disabled) {
border-color: var(--rs-color-border-danger-emphasis-hover);
}

.error:focus {
.error:focus:not(:disabled) {
border-color: var(--rs-color-border-danger-emphasis-hover);
}

Expand All @@ -113,5 +113,5 @@
}

.helperTextDisabled {
color: var(--rs-color-foreground-base-tertiary);
}
opacity: 0.5;
}
1 change: 0 additions & 1 deletion packages/raystack/components/toggle/toggle.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
}

.toggle[data-disabled] {
cursor: not-allowed;
opacity: 0.5;
pointer-events: none;
}
Expand Down
Loading