edatec Open Source‌ HMI for 10 inches panel driver by spp-bruk · Pull Request #7362 · raspberrypi/linux

spp-bruk · 2026-05-13T10:03:59Z

this is 10 inches panel driver please check them , thanks!

Signed-off-by: lzunspp <bli@edatec.cn>

6by9

I'd missed that you'd posted both the 7" and 10" drivers yesterday.

The only changes I would expect to see to panel-ilitek-ili9881c.c is to add the init sequence, timing, descriptor, and compatible string. All the rest should be achievable in device tree.

The regulator driver here is near identical to that baked into the panel driver for the 7". This driver should be reused on the 7".

6by9 · 2026-05-14T16:29:57Z

 	msleep(20);

+	if (is_rzw) {
+		gpiod_set_value_cansleep(ctx->reset, 1);


No. If you need to invert the sense of a GPIO, do so in device tree
eg

reset-gpios = <&reg_display 2 1>;

or preferably

#include <dt-bindings/gpio/gpio.h> ... reset-gpios = <&reg_display 2 GPIO_ACTIVE_LOW>;

6by9 · 2026-05-14T16:35:36Z

-	gpiod_set_value_cansleep(ctx->reset, 1);
+	if (is_rzw_t101p136cq_panel(ctx)) {
+		gpiod_set_value_cansleep(ctx->reset, 0);
+		msleep(100);


Why do you need extra time when turning off?

If you need a minimum of 100ms between turning off and on again, then do it in device tree for the regulator

off-on-delay-us = <100000>;

i see turing off panel don't need delay , i will delete . this is copy from source driver , diffirent kernel version source code has little diffirent .

6by9 · 2026-05-14T16:40:39Z

+	.height_mm	= 216,
+};
+
+static const struct drm_display_mode t101p136cq_rpi5_2lane_mode = {


Isn't this identical to t101p136cq_rpi4_2lane_mode?

yes it's the same , i will delete this config

6by9 · 2026-05-14T16:42:15Z

+};
+
+static const struct drm_display_mode t101p136cq_rpi4_2lane_mode = {
+	.clock		= 78086,		//60Hz


If the only difference between t101p136cq_default_mode and this is that one runs over 4 lanes, then the timings shouldn't need to change.

because , in early time 2 lan can't arrive 60 HZ so we Separate config . we will use the same timings config

6by9 · 2026-05-14T16:42:30Z

@@ -0,0 +1,355 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (C) 2020 Marek Vasut <marex@denx.de>


i'm sorry , i will delete this

6by9 · 2026-05-14T16:52:20Z

+};
+
+static const struct gpio_signal_mappings mappings[NUM_GPIO] = {
+	[LCD_BL_EN_N] = { REG_OUTPUT, PIN_LCD_BL_EN },


Why the need for this lookup table? Just copying and pasting from a different driver is not always the best policy.

this reason is same with 7 inches branch.
this is mcu code：
gpio_bit_write(GPIOA, GPIO_PIN_4, RESET); //LCD BL PWM
gpio_bit_write(GPIOA, GPIO_PIN_5, SET); //LCD_RST_L
gpio_bit_write(GPIOA, GPIO_PIN_6, SET); //TP_RST_L
gpio_bit_write(GPIOA, GPIO_PIN_7, SET); //LCD BL EN
we will control and used this gpios in mcu .

this is soc driver code:
static const struct gpio_signal_mappings mappings[NUM_GPIO] = {
[LCD_BL_EN_N] = { REG_OUTPUT, PIN_LCD_BL_EN },
[LCD_BL_PWM_N] = { REG_OUTPUT, PIN_LCD_BL_PWM },
[LCD_RST_N] = { REG_OUTPUT, PIN_LCD_RST },
[TP_RST_N] = { REG_OUTPUT, PIN_TP_RST },
};
LCD_BL_EN_N enable lcd backlight
LCD_BL_PWM_N this is control blacklight pwm
LCD_RST_N LCD reset pin
TP_RST_N TP reset pin

6by9 · 2026-05-14T16:53:26Z

@@ -0,0 +1,183 @@
+# CONFIG_LOCALVERSION_AUTO is not set


Why do we need a special defconfig for this hardware?

because we will add REGULATOR_EDATEC_10INCH=m ,no this deconfig . which file can we write this config ？ if we add config to other defconfig It may affect other files

6by9 · 2026-05-14T16:54:42Z

+			vdd_lcd: fixedregulator_lcd {
+				compatible = "regulator-fixed";
+				regulator-name = "vdd_lcd";
+				regulator-max-microvolt = <5000000>;


Defining the voltages is fairly redundant when it is a fixed regulator.

bias IC support voltage for backlight ic , bias IC will support diffirent voltage with diffirent backlight ic . this config can meet the requirements

6by9 · 2026-05-14T16:58:06Z

+				regulator-min-microvolt = <5000000>;
+
+				gpios = <&reg_display 4 0>;
+				regulator-boot-on;


This feels like an odd property to be setting on this regulator
Docs at https://github.com/raspberrypi/linux/blob/rpi-6.18.y/Documentation/devicetree/bindings/regulator/regulator.yaml#L44-L51

It's expected that this regulator was left on by the bootloader. If the bootloader didn't leave it on then OS should turn it on at boot but shouldn't prevent it from being turned off later. This property is intended to only be used for regulators where software cannot read the state of the regulator.

yes this dts is config for edatec-panel-regulator.c

6by9 · 2026-05-14T17:16:32Z

+	.init = t101p136cq_2lane_init,
+	.init_length = ARRAY_SIZE(t101p136cq_2lane_init),
+	.mode = &t101p136cq_rpi5_2lane_mode,
+	.mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_LPM,


Why the difference in the flags between these variants?
vc4 currently ignores almost all of them anyway.

static const struct ili9881c_desc t101p136cq_rpi4_lite_desc = {
.init = t101p136cq_2lane_init,
.init_length = ARRAY_SIZE(t101p136cq_2lane_init),
.mode = &t101p136cq_rpi4_2lane_mode,
.mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST | MIPI_DSI_MODE_LPM,
.lanes = 2,
};

static const struct ili9881c_desc t101p136cq_rpi5_desc = {
.init = t101p136cq_2lane_init,
.init_length = ARRAY_SIZE(t101p136cq_2lane_init),
.mode = &t101p136cq_rpi5_2lane_mode,
.mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_LPM,
.lanes = 2,
};

you mean this two config mode_flags shoule be the same ? we merge some drivers code in all one , and copy config from source code.

spp-bruk force-pushed the rpi-6.18.y branch from 6a2d45b to b3e4e12 Compare May 14, 2026 06:08

feat(display):eadtec Open Source‌ HMI for 10 inches panel driver

89217af

Signed-off-by: lzunspp <bli@edatec.cn>

spp-bruk force-pushed the rpi-6.18.y branch from b3e4e12 to 89217af Compare May 14, 2026 06:14

spp-bruk changed the title ~~eadtec Open Source‌ HMI for 10 inches panel driver~~ edatec Open Source‌ HMI for 10 inches panel driver May 14, 2026

6by9 reviewed May 14, 2026

View reviewed changes

Conversation

spp-bruk commented May 13, 2026

Uh oh!

6by9 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

spp-bruk May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

spp-bruk May 15, 2026 •

edited

Loading