Skip to content

Fix typo and improve build.sh error handling #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
awanawana wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix typo and improve build.sh error handling #16

awanawana wants to merge 1 commit into from

Conversation

@awanawana
Copy link

@awanawana awanawana commented Feb 11, 2026

Summary

This PR fixes a typo in the README and adds proper cleanup handling in build.sh.

Changes

  • Fix typo in README.md: 'controvery' -> 'controversy' (line 86)
  • Add cleanup trap in build.sh to properly handle temporary file on exit
  • Move tmp_file declaration to local scope inside build_template() function
  • Clear tmp_file variable after mv to prevent cleanup from trying to remove the successfully created template.sh

Impact

  • The typo fix improves documentation quality
  • The build.sh improvement ensures temporary files are properly cleaned up even if the script fails unexpectedly

🤖 Generated with Claude Code

@awanawana
Fix typo and improve build.sh error handling
7597b52 
- Fix typo in README.md: 'controvery' -> 'controversy' (line 86)
- Add cleanup trap in build.sh to properly handle temporary file on exit
- Clear tmp_file variable after mv to prevent cleanup from trying to remove the successfully created template.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@awanawana