test(workspace-helpers): add unit tests + fix off-by-one in extractCustomAgentName#599
Merged
test(workspace-helpers): add unit tests + fix off-by-one in extractCustomAgentName#599
Conversation
…stomAgentName Add 36 unit tests covering getModeType, getRepoDisplayName, parseGitRemoteUrl, isMcpTool, normalizeMcpToolName, extractMcpServerName, extractCustomAgentName, and getEditorNameFromRoot. All functions are pure string transformations so tests use inline fixtures with no mocks. Also fix a pre-existing bug discovered by the tests: extractCustomAgentName was calling slice(0, -10) to strip '.agent.md' but that suffix is only 9 characters, causing the last character of the agent name to be silently dropped. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 36 unit tests for workspaceHelpers.ts, covering the pure string-transformation functions that determine session attribution (editor, repository, mode, MCP tools). Also fixes a pre-existing off-by-one bug discovered by the tests.
Bug fixed
extractCustomAgentName was calling slice(0, -10) to strip the .agent.md suffix, but that suffix is 9 characters, not 10. This silently dropped the last character of every custom agent name (e.g. "my-agent" became "my-agen"). Changed to slice(0, -9).
What's tested
Approach
All functions under test are pure string transformations. Tests use inline fixture strings -- no mocks, no file I/O.