fix(workflows): consolidate VS extension release into release.yml#597
Merged
fix(workflows): consolidate VS extension release into release.yml#597
Conversation
- Fix build-visualstudio job condition: was skipping on normal workflow_dispatch (condition 'event_name == push || vs_only == true' evaluated false for default dispatch runs where vs_only defaults to false) - Add vscode_only input to workflow_dispatch so VS Code-only releases can skip the VS extension build - Remove vs/v* tag trigger from visualstudio-build.yml (releases now go through release.yml) - Remove workflow_dispatch from visualstudio-build.yml (releases now go through release.yml) - Remove marketplace publish step from visualstudio-build.yml (eliminates the VS_MARKETPLACE_PAT secret name bug; release.yml correctly uses VSCE_PAT) - Remove github-release job from visualstudio-build.yml (releases go through release.yml) - visualstudio-build.yml is now CI-only: build + test on PRs and branch pushes Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Three separate issues were found by analyzing recent failed/skipped workflow runs:
1.
release.ymlsilently skipped VS extension on normalworkflow_dispatch(run #24292416722)The
build-visualstudiojob had this condition:On a standard
workflow_dispatchwith defaults,event_nameis'workflow_dispatch'(not'push') andvs_onlydefaults tofalse→ always skipped.The only reason the VS-only run #24292659528 worked was because
vs_only=truewas explicitly set.2.
visualstudio-build.ymlfailed with missing secret (run #24292599081)The standalone workflow used
secrets.VS_MARKETPLACE_PATwhich doesn't exist.release.ymlalready had the right answer in a comment:secrets.VSCE_PAT # same one works for VS Marketplace.3. Two separate release paths for the VS extension (confusing)
visualstudio-build.ymlhad its ownvs/v*tag trigger +workflow_dispatchwith marketplace publish, duplicating thebuild-visualstudiojob inrelease.yml.Changes
release.ymlbuild-visualstudiojob condition fromgithub.event_name == 'push' || inputs.vs_only == true→inputs.vscode_only != true(runs for all triggers unless explicitly excluded)vscode_onlyboolean input (complement to existingvs_only) — allows releasing only the VS Code extension without triggering the Windows VS buildvisualstudio-build.yml→ CI-onlyvs/v*tag trigger (releases go throughrelease.yml)workflow_dispatchwithpublish_marketplaceinput (releases go throughrelease.yml)VS_MARKETPLACE_PATsecret reference)github-releasejob (releases go throughrelease.yml)contents: write)Result
workflow_dispatchnormal releaseworkflow_dispatchvs_only=trueworkflow_dispatchvscode_only=truevscode/v*tag pushworkflow_dispatchrelease.ymlwithvs_only=true✅