Skip to content

Update ROI 2019 dataset ahead of Island of Ireland merge#3457

Open
claudiavalkenier wants to merge 1 commit into
masterfrom
updateROI2019_IE_2026
Open

Update ROI 2019 dataset ahead of Island of Ireland merge#3457
claudiavalkenier wants to merge 1 commit into
masterfrom
updateROI2019_IE_2026

Conversation

@claudiavalkenier

@claudiavalkenier claudiavalkenier commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Context

As part of a project to combine the Republic of Ireland (ROI) and Northern Ireland datasets into a single Island of Ireland dataset, this PR refines the existing ROI 2019 dataset.

Related

Checklist

  • I have tested these changes
  • I have updated documentation as needed
  • I have tagged the relevant people for review

Tagging @kndehaan as reviewer

@claudiavalkenier claudiavalkenier changed the title Dataset update Ireland 2019 Update ROI 2019 dataset ahead of Island of Ireland merge Jul 8, 2026
@claudiavalkenier
claudiavalkenier requested a review from kndehaan July 8, 2026 08:28
- has_coastline = true
- has_industry = true
- has_lignite = true
- has_lignite = false

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something you changed? If so, what was the reason that this was changed?

@claudiavalkenier claudiavalkenier Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't something I directly changed actually... However, I note that in the previous dataset, a lignite key (input_energy_power_ultra_supercritical_lignite_production) used to be 6991 TJ and is changed to 0 TJ. (there is only one single coal-fired power plant in Ireland, and no lignite). Maybe this has changed automatically?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noracato Is it possible that has_lignite automatically changes?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The has_lignite is not an ETLocal attribute. So if you re-export the dataset, it will be overwritten with the default value for has_lignite, which is false.

I'm changing this by hand for now and will open a separate issue for this.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking further into this @claudiavalkenier, good that you're creating an issue for this.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created an issue with some background: see quintel/etlocal#700

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants