Exclude known split ids; double merge concurrency#6452
Merged
Conversation
nadav-govari
commented
May 20, 2026
| compaction_root_directory: TempDirectory, | ||
| ) -> Self { | ||
| let num_pipeline_slots = max_concurrent_merge_executions * 2; | ||
| let pipelines = (0..num_pipeline_slots).map(|_| None).collect(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Better utilize resources - semaphore for merge executions, everything else is IO. It allows us to run interleave pipelines better and get more net merges out with less resources. Will make this configurable in a future PR.
Also added the list of tracked splits to exclude from the metastore scan. This is necessary because before, we'd always fetch the 5000 oldest splits that are not yet mature. At a certain point we end up retrieving all of the splits that make up pending L3+ merges, and since those are already tracked, it's keeping us from scanning newer splits that are better candidates to be merged.
How was this PR tested?
Describe how you tested this PR.