Performance improvements: multipart upload, parallel gets, spans#6451
Open
nadav-govari wants to merge 1 commit into
Open
Performance improvements: multipart upload, parallel gets, spans#6451nadav-govari wants to merge 1 commit into
nadav-govari wants to merge 1 commit into
Conversation
nadav-govari
commented
May 20, 2026
| /// We want to balance time spent waiting on uploads while still being careful about | ||
| /// not hammering S3 Puts, which can be expensive. | ||
| /// TODO: Dynamic multipart policy. | ||
| target_part_num_bytes: 512 * 1_024 * 1_024, // 5GB |
Collaborator
Author
There was a problem hiding this comment.
use bytesize for all these values
| /// We want to balance time spent waiting on uploads while still being careful about | ||
| /// not hammering S3 Puts, which can be expensive. | ||
| /// TODO: Dynamic multipart policy. | ||
| target_part_num_bytes: 512 * 1_024 * 1_024, // 5GB |
Collaborator
Author
There was a problem hiding this comment.
leave this as it was and update it for our own purposes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added spans for the S3 operations. Parallelized merge split download operations, added S3 timing metrics, and reduced the bar to chunk multipart uploads from 5gb to 512mb. Fixed the index migration.
How was this PR tested?
Dogfooding cluster.