Add integration test showcasing resendMessages bug #344 (too-low SequenceReset MsgSeqNum)#1195
Add integration test showcasing resendMessages bug #344 (too-low SequenceReset MsgSeqNum)#1195
Conversation
…ve acceptor/initiator connection Agent-Logs-Url: https://github.com/quickfix-j/quickfixj/sessions/51698dc5-437b-4294-9bc1-1f77b2c74796 Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
|
@copilot please add logging to the toAdmin/fromAdmin/toApp/fromApp methods in the ApplicationAdapter in the test implementation. |
… and TestConnectorApplication Agent-Logs-Url: https://github.com/quickfix-j/quickfixj/sessions/f97854dd-c016-45b5-8b11-6d0c47ff8fe6 Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
Done in commit 2d30768. Both |
|
@copilot I cannot see any session-related events being logged in the test. Please pass a LogFactory to the Session. |
…n test output Agent-Logs-Url: https://github.com/quickfix-j/quickfixj/sessions/c3898893-28b5-44c2-b652-a134c6ab2747 Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
Done in commit 68bbb0f. Replaced |
|
@copilot change test as follows:
|
…oo-low text Agent-Logs-Url: https://github.com/quickfix-j/quickfixj/sessions/a782b3cc-5406-494c-a244-300ae1081f6e Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
Done in commit fb0c0d5. Changes made:
|
…ore generateSequenceResetIfNeeded Agent-Logs-Url: https://github.com/quickfix-j/quickfixj/sessions/be2e37cc-175b-4fcb-89ea-6f5c4b7b68b1 Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
- Simplify BugScenarioStore: NextSenderMsgSeqNum 11→6, remove absent seqnos 6–10 - Update capture threshold in AcceptorApplication.toAdmin from >10 to >6 - Update test sanity-check assertion from newSeqNo>10 to newSeqNo>6 - Revert Session.java condition to `if (appMessageJustSent)` to expose bug #344 Agent-Logs-Url: https://github.com/quickfix-j/quickfixj/sessions/5c8e8307-ada1-4ff4-ac56-49ef2abd8957 Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
- Add second Heartbeat (seqno 6) to BugScenarioStore; LAST_PREPOPULATED_SEQNO 5→6 - setNextSenderMsgSeqNum 6→7 so the startup Logon uses seqno 7 - Update toAdmin capture threshold from >6 to >7 (NewSeqNo=8 is the buggy reset) - Update sanity-check assertion from >6 to >7 - Update assertEquals(6) → assertEquals(7) and related comments - Update all Javadoc to reflect new seqno 6 Heartbeat and seqno 7 Logon Agent-Logs-Url: https://github.com/quickfix-j/quickfixj/sessions/6093151b-7a97-484c-a0b4-5528eaae35e7 Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
Agent-Logs-Url: https://github.com/quickfix-j/quickfixj/sessions/c38eb35a-93d2-413b-bf85-4884ea7653fc Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
ResendMessagesBugDirectConnectionTest.javato the state at commit367788275ff7e2d5e2f3bd4481beca58c538f9e6