Draft
Conversation
vezwork
changed the title
Contributor
📝 Preview Deployment🔍 Full site preview: https://deploy-preview-1890.quarto.org 🔄 Modified Documents |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a prototype of a
<details>element based tabset. The tabset is visually and functionally identical to the existing tabset (although the styling is more hard-coded and e.g. doesn't support light mode for now).It would be good to use the details elements for tabsets because it enables ctrl+f'ing into tabsets, text-fragment linking into tabsets, and may work well for search indexing, reportedly unlike bootstrap tabsets. It might also be good to have more control over our tabsets, so we could add e.g. better print styles (as suggested by @mine-cetinkaya-rundel).
Using (mutually exclusive) details elements here is semantic html, so it should be decent for accessibility; but bootstrap has put a lot of work into making their solution accessible, so we should be mindful of that.
Further prototyping work
A full prototype of this should be a Quarto extension. The Quarto extension would have a Lua filter that processess tabset syntax into the div structure shown in this prototype code. The extension would also contain the css, that I currently have inlined in the qmd, in its own file.
Reference
https://codepen.io/RYJASM/pen/eYoYeRg