Skip to content

Fix runtimelib deprecation warning#24

Merged
shikokuchuo merged 1 commit intomainfrom
depr
Mar 4, 2026
Merged

Fix runtimelib deprecation warning#24
shikokuchuo merged 1 commit intomainfrom
depr

Conversation

@shikokuchuo
Copy link
Collaborator

Fix deprecated runtimelib::create_client_shell_connection call by migrating to create_client_shell_connection_with_identity with a PeerIdentity from peer_identity_for_session.

error: use of deprecated function                                         
  `runtimelib::create_client_shell_connection`: Use                         
  create_client_shell_connection_with_identity with a PeerIdentity from         
  peer_identity_for_session instead                                         
     --> crates/quarto-core/src/engine/jupyter/daemon.rs:157:25                 
      |                                                                     
  157 |                                                                     
  runtimelib::create_client_shell_connection(&connection_info, &session_id) 
      |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^              
      |                                                                     
      = note: `-D deprecated` implied by `-D warnings`                      
      = help: to override `-D warnings` add `#[allow(deprecated)]`          
                                                                            
     Compiling quarto-hub v0.1.0                                            
  (/home/runner/work/q2/q2/crates/quarto-hub)

@shikokuchuo shikokuchuo merged commit 6624e7f into main Mar 4, 2026
4 checks passed
@shikokuchuo shikokuchuo deleted the depr branch March 4, 2026 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant