Revert "Arm backend: Make composable_quantizer default"#20982
Revert "Arm backend: Make composable_quantizer default"#20982digantdesai wants to merge 1 commit into
Conversation
This reverts commit 432353a.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20982
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 3 Unclassified FailuresAs of commit 913eb73 with merge base 2ecfc10 ( NEW FAILURE - The following job has failed:
UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
There was a problem hiding this comment.
Pull request overview
This PR reverts the earlier change that made the Arm backend’s composable quantizer the default, restoring the legacy/default quantizer as the default implementation while keeping the composable quantizer behind an opt-in flag.
Changes:
- Switch
use_composable_quantizerdefaults back toFalseacross Arm quantizers, update warnings/docs accordingly, and refresh the public API manifest signatures. - Update Arm tests and tutorial/docs to align with the reverted default (including removing a composable-specific while-loop test).
- Adjust quantization behavior around
to.dtypeinteger→float output qspec handling and update related tests/expectations.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| examples/arm/quantizer_tutorial.ipynb | Marks the composable-quantizer tutorial as WIP/experimental and adds an explicit warning + issue link. |
| docs/source/backends/arm-vgf/arm-vgf-quantization.md | Updates VGF quantizer default flag and warning text to reflect composable being experimental/opt-in. |
| docs/source/backends/arm-ethos-u/arm-ethos-u-quantization.md | Updates Ethos-U quantizer default flag and warning text to reflect composable being experimental/opt-in. |
| backends/arm/test/ops/test_while.py | Removes composable-quantizer-specific while-loop test and related imports. |
| backends/arm/test/ops/test_transpose_conv2d.py | Updates config type usage to QuantizationConfig and adjusts imports accordingly. |
| backends/arm/test/ops/test_to_copy.py | Tweaks TOSA INT cast test setup and splits redundant-cast xfails between FP/INT. |
| backends/arm/test/models/test_torch_functions.py | Simplifies nonzero test wiring and removes the special-case quantizer IO override. |
| backends/arm/test/misc/test_shared_qspecs.py | Updates expected qspec mappings/counts to match the reverted quantizer behavior. |
| backends/arm/test/misc/test_quant_custom_meta.py | Removes a quantizer IO override that was tied to the previous default behavior. |
| backends/arm/quantizer/quantization_config.py | Broadens integer→float to.dtype fixed-output qspec behavior from float32-only to any floating-point output. |
| backends/arm/quantizer/arm_quantizer.py | Restores default use_composable_quantizer=False, updates warnings/log messaging, and tightens legacy vs composable property behavior. |
| backends/arm/public_api_manifests/api_manifest_running.toml | Updates public API signatures for EthosU/VGF quantizers to reflect the reverted default parameter value. |
| backends/arm/_passes/normalize_while_initial_args_pass.py | Changes placeholder meta propagation for cloned placeholders in while normalization. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ) | ||
| cloned_placeholders.append(clone) | ||
| clone.meta = placeholder.meta.copy() | ||
| clone.meta = placeholder.meta |
| and will be removed in two minor releases. See | ||
| [issue #17701](https://github.com/pytorch/executorch/issues/17701) | ||
| for details. | ||
| - **use_composable_quantizer (bool)**: Whether to use the composable quantizer implementation. See https://github.com/pytorch/executorch/issues/17701" for details. |
| and will be removed in two minor releases. See | ||
| [issue #17701](https://github.com/pytorch/executorch/issues/17701) | ||
| for details. | ||
| - **use_composable_quantizer (bool)**: Whether to use the composable quantizer implementation. See https://github.com/pytorch/executorch/issues/17701" for details. |
| and will be removed in two minor releases. See | ||
| [issue #17701](https://github.com/pytorch/executorch/issues/17701) | ||
| for details. | ||
| use_composable_quantizer (bool): Whether to use the composable quantizer implementation. See https://github.com/pytorch/executorch/issues/17701" for details. |
| and will be removed in two minor releases. See | ||
| [issue #17701](https://github.com/pytorch/executorch/issues/17701) | ||
| for details. | ||
| use_composable_quantizer (bool): Whether to use the composable quantizer implementation. See https://github.com/pytorch/executorch/issues/17701" for details. |
Reverts #19758
cc @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani