Arm backend: Normalize grid-sampler custom inputs to NHWC#20965
Open
robell wants to merge 1 commit into
Open
Conversation
This fixes a bug on input tensor order vs shader expectations. Ensure VGF grid_sample custom inputs are in the layout expected by the shader interface. The rewrite now permutes the sampled tensor from NCHW to NHWC beforectosa.CUSTOM, preserves the grid input as-is, and permutes the custom result back to NCHW afterward. Change-Id: Iccd829964e1142803ddb771ad5c3f405136d0d55 Signed-off-by: Rob Elliott <Robert.Elliott@arm.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20965
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 80c5012 with merge base a6aaeff ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arm backend: Normalize grid-sampler custom inputs to NHWC
This fixes a bug on input tensor order vs shader expectations.
Ensure VGF grid_sample custom inputs are in the layout expected by the
shader interface. The rewrite now permutes the sampled tensor from NCHW
to NHWC beforectosa.CUSTOM, preserves the grid input as-is, and
permutes the custom result back to NCHW afterward.
This functions well with the newer tensor ordering rules in the Arm backend.
Change-Id: Iccd829964e1142803ddb771ad5c3f405136d0d55
Signed-off-by: Rob Elliott Robert.Elliott@arm.com
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @rascani