Fix NeutronConverterManager pickle error with forkserver multiprocessing (#19855)#19855
Fix NeutronConverterManager pickle error with forkserver multiprocessing (#19855)#19855JakeStevens wants to merge 1 commit into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19855
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Pending, 3 Unrelated FailuresAs of commit 5803585 with merge base 88faab2 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
|
@JakeStevens has exported this pull request. If you are a Meta employee, you can view the originating Diff in D106689031. |
This PR needs a
|
meta-codesync
Bot
changed the title
…ing (pytorch#19855) Summary: Refactors convert_unsafe() to pass picklable dict instead of unpicklable module/C++ objects, adds TypeError to fallback handler (both fbcode + xplat copies) Differential Revision: D106689031
JakeStevens
force-pushed
the
export-D106689031
branch
from
d063335 to
a81da5d
Compare
…ing (pytorch#19855) Summary: Refactors convert_unsafe() to pass picklable dict instead of unpicklable module/C++ objects, adds TypeError to fallback handler (both fbcode + xplat copies) Differential Revision: D106689031
JakeStevens
force-pushed
the
export-D106689031
branch
from
a81da5d to
7b22934
Compare
robert-kalmar
added
the
module: nxp
MartinPavella
left a comment
MartinPavella
left a comment
There was a problem hiding this comment.
With the typo and linting fixed. LGTM
|
|
||
|
|
||
| def test_convert_unsafe_args_are_picklable(mocker): | ||
| """Verify that all args passed to multiprocessing.Process are picklable. |
There was a problem hiding this comment.
Typo: multiprocessing.Process
There was a problem hiding this comment.
Sorry, what is the typo? looks the same to me at least
There was a problem hiding this comment.
Minor: missing space btw. the . and the Process.
There was a problem hiding this comment.
I'm sorry. I also thought it was supposed to be 2 sentences. I didn't realize the period was accessing the Process member of multiprocessing.
In that case, there is no typo. Just perhaps it could be surrounded with apostrophes or something, since it confused me and Robert too :D
`multiprocessing.Process`
…ing (pytorch#19855) Summary: Refactors convert_unsafe() to pass picklable dict instead of unpicklable module/C++ objects, adds TypeError to fallback handler (both fbcode + xplat copies) Differential Revision: D106689031
JakeStevens
force-pushed
the
export-D106689031
branch
from
7b22934 to
5803585
Compare
3 participants
Summary:
Refactors convert_unsafe() to pass picklable dict instead of unpicklable module/C++ objects, adds TypeError to fallback handler (both fbcode + xplat copies)
Differential Revision: D106689031