Add MLX hardtanh op handler#19776
Open
atharvjairath wants to merge 6 commits into
Open
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19776
Note: Links to docs will display an error until the docs builds have been completed. ❗ 2 Active SEVsThere are 2 currently active SEVs. If your PR is affected, please view them below:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
|
Author
|
@pytorchbot label "release notes: apple" |
Author
|
cc: @nil-is-all |
Author
|
Friendly bump, PR is ready for review. Added MLX support for Would appreciate a review when possible. cc @metascroy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18921
Adds MLX delegate support for
aten.hardtanh.defaultby lowering it to the existingClipNodepath with the operator'smin_valandmax_valbounds. This enables bounded activation models, including ReLU6-style hardtanh usage, to stay delegated to MLX instead of failing as an unsupported op.This also adds focused MLX op tests for:
[-1.0, 1.0][0.0, 6.0][-2.0, 2.0][-0.25, 0.75]Test plan:
This follows up on #18986 by adding custom min/max bound coverage and including the requested local test output.