Skip to content

Fix Multiple constraints for allocation for two cat inputs of same underlying tensor (#18830)#18830

Open
ethansfng wants to merge 1 commit intopytorch:mainfrom
ethansfng:export-D100494796
Open

Fix Multiple constraints for allocation for two cat inputs of same underlying tensor (#18830)#18830
ethansfng wants to merge 1 commit intopytorch:mainfrom
ethansfng:export-D100494796

Conversation

@ethansfng
Copy link
Copy Markdown
Contributor

@ethansfng ethansfng commented Apr 12, 2026

Summary:

Added a resolved-source duplicate check in is_removable_cat_op. After the existing node-identity duplicate check, it follows each input's alias chain to its ultimate source and checks for duplicates among the resolved sources. If two inputs resolve to the same tensor, the cat is not optimizable.

Differential Revision: D100494796

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 12, 2026
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Apr 12, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18830

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 New Failures, 2 Unrelated Failures

As of commit 786d367 with merge base 411ede2 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync bot commented Apr 12, 2026

@ethansfng has exported this pull request. If you are a Meta employee, you can view the originating Diff in D100494796.

@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync meta-codesync bot changed the title Fix Multiple constraints for allocation for two cat inputs of same underlying tensor Fix Multiple constraints for allocation for two cat inputs of same underlying tensor (#18830) Apr 12, 2026
ethansfng added a commit to ethansfng/executorch that referenced this pull request Apr 12, 2026
…derlying tensor (pytorch#18830)

Summary:

Added a resolved-source duplicate check in is_removable_cat_op. After the existing node-identity duplicate check, it follows each input's alias chain to its ultimate source and checks for duplicates among the resolved sources. If two inputs resolve to the same tensor, the cat is not optimizable.

Differential Revision: D100494796
…derlying tensor (pytorch#18830)

Summary:

Added a resolved-source duplicate check in is_removable_cat_op. After the existing node-identity duplicate check, it follows each input's alias chain to its ultimate source and checks for duplicates among the resolved sources. If two inputs resolve to the same tensor, the cat is not optimizable.

Differential Revision: D100494796
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant