Python runtime rework #4222
Open
cehongwang wants to merge 13 commits intomainfrom
Open
Conversation
Signed-off-by: Torch-TensorRT Github Bot <torch-tensorrt.github.bot@nvidia.com>
github-actions
Bot
added
documentation
narendasan
reviewed
Apr 29, 2026
Collaborator
narendasan
left a comment
narendasan
left a comment
There was a problem hiding this comment.
Not sure this PR is clean yet
| : TRTEngine::ResourceAllocationStrategy::kStatic); | ||
| }) | ||
| .def_readwrite("use_pre_allocated_outputs", &TRTEngine::use_pre_allocated_outputs) | ||
| .def_readwrite("pre_allocated_outputs", &TRTEngine::pre_allocated_outputs) |
Collaborator
Author
There was a problem hiding this comment.
The first one is the flag, and the second one is the tensor. There is a test that compares the output tensor pointer to verify it is the same tensor. So the second one is needed
| .. code-block:: python | ||
|
|
||
| tp_group = dist.new_group(ranks=[0, 1]) | ||
| with torch_tensorrt.distributed.distributed_context(tp_group, trt_model) as model: |
Collaborator
There was a problem hiding this comment.
Are we keeping this or removing it?
cehongwang
force-pushed
the
python-runtime-rework-patches
branch
from
daad718 to
a328e80
Compare
cehongwang
force-pushed
the
python-runtime-rework-patches
branch
from
a328e80 to
00e4ea2
Compare
cehongwang
force-pushed
the
python-runtime-rework-patches
branch
from
00e4ea2 to
168bdea
Compare
Collaborator
Author
|
I will revert the commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: