Skip to content

Communities page WIP#4566

Draft
marcoacierno wants to merge 1 commit intomainfrom
communities-pages
Draft

Communities page WIP#4566
marcoacierno wants to merge 1 commit intomainfrom
communities-pages

Conversation

@marcoacierno
Copy link
Member

What

ToDo

@vercel
Copy link

vercel bot commented Feb 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pycon Error Error Feb 7, 2026 7:32pm

@claude
Copy link
Contributor

claude bot commented Feb 7, 2026

Summary

This PR adds a new local_communities content source option to the dynamic content display section, enabling a communities page. The implementation includes backend enum changes, CMS block configuration, and a frontend component with hardcoded placeholder data.

Issues

Architecture & Design

Hardcoded data in UI component (frontend/src/components/blocks/dynamic-content-display-section/local-communities-content.tsx:18-82)

  • The component renders hardcoded mock data ([1, 2, 3, 4, 5, 6, 7, 8, 9, 10].map()) with static text, images, and social links
  • All 10 cards display identical "Python Bari" information with hardcoded URLs
  • This should either:
    • Fetch real data via GraphQL (like other content types in this component)
    • Be clearly marked as a draft/placeholder if this is intentional for the WIP PR

Missing data layer (frontend/src/components/blocks/dynamic-content-display-section/index.tsx:63-65)

  • The dataFetching function returns an empty array for LocalCommunities, but the component needs actual community data
  • Unlike Speakers, Keynoters, and Proposals which query real data, this has no backend integration

Code Quality

Unused import (frontend/src/components/blocks/dynamic-content-display-section/local-communities-content.tsx:7)

  • MultiplePartsCardCollection is imported but never used

Inconsistent JSX configuration (frontend/tsconfig.json:16)

  • Changing from jsx: "preserve" to jsx: "react-jsx" affects the entire frontend build
  • This change seems unrelated to adding a communities page
  • If this is needed for the new component, it should be explained in the PR description
  • Consider whether this affects existing components or build output

Missing Implementation

Given this is marked WIP, the following are expected to be completed:

  • Backend GraphQL query/resolver for fetching local communities data
  • Database model or data source for communities
  • Frontend GraphQL query integration
  • Remove hardcoded placeholder data

@codecov
Copy link

codecov bot commented Feb 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.16%. Comparing base (f846f94) to head (09b5ed9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4566   +/-   ##
=======================================
  Coverage   94.16%   94.16%           
=======================================
  Files         353      353           
  Lines       10347    10348    +1     
  Branches      761      761           
=======================================
+ Hits         9743     9744    +1     
  Misses        502      502           
  Partials      102      102           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant