Skip to content

Communities page WIP#4566

Draft
marcoacierno wants to merge 6 commits intomainfrom
communities-pages
Draft

Communities page WIP#4566
marcoacierno wants to merge 6 commits intomainfrom
communities-pages

Conversation

@marcoacierno
Copy link
Member

What

ToDo

@vercel
Copy link

vercel bot commented Feb 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pycon Error Error Feb 26, 2026 4:31am

@claude
Copy link
Contributor

claude bot commented Feb 7, 2026

This PR is a WIP draft adding a Communities page section — a new Wagtail CMS block, GraphQL API type, migration, and frontend React component. Several issues need attention before it's ready:

1. title prop is never rendered (frontend bug)
In communities-section.tsx, the title prop is destructured and passed in but never used in the JSX output. The section heading is missing entirely.

2. Unused fields fetched from GraphQL
bannerPhoto and bannerBackgroundColor are queried in the GraphQL fragment but are not consumed anywhere in the frontend component. Either implement their usage or remove them from the fragment.

3. CMS/API field nullability mismatch
In the CMS block (cms/components/page/blocks/communities_section.py), logo is required=True, but the API type declares it as logo: str | None and handles it as nullable. These should be consistent.

4. tsconfig.json jsx change is project-wide
Changing "jsx": "preserve" to "jsx": "react-jsx" affects the entire frontend project, not just communities. This change should be intentional and tested — it can break existing components depending on how JSX transforms work. If this was needed to fix a compilation error in the new component, explain why; otherwise revert.

5. No tests for the new API block
The CommunitiesSection API resolver (backend/api/cms/page/blocks/communities_section.py) has no tests. Other block types in this project have corresponding test coverage. At minimum the from_block methods (especially the image rendition logic) should be tested.

@codecov
Copy link

codecov bot commented Feb 7, 2026

Codecov Report

❌ Patch coverage is 85.18519% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.45%. Comparing base (6b43dee) to head (dda0161).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4566      +/-   ##
==========================================
- Coverage   92.52%   92.45%   -0.07%     
==========================================
  Files         357      359       +2     
  Lines       10690    10751      +61     
  Branches      812      815       +3     
==========================================
+ Hits         9891     9940      +49     
- Misses        687      699      +12     
  Partials      112      112              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant