Split linting from main workflow#144
Merged
Merged
Conversation
Collaborator
Author
|
Posted a PR fixing the failure cause: python/cpython#151343 |
Member
Thanks, merged! |
| - run: git add . | ||
| - run: git commit -m "$(python manage_translation.py generate_commit_msg)" | ||
| if: env.SIGNIFICANT_CHANGES | ||
| - name: Push commit |
Member
There was a problem hiding this comment.
This shouldn't run on PRs IMO. This causes issues like https://github.com/python/python-docs-pl/actions/runs/27407678283/job/81000784306?pr=144.
…t correct permissions, add run-id and auth to download artifact job
Collaborator
Author
|
@copilot resolve the merge conflicts in this pull request |
Member
|
Oh no, sorry this slipped my mind. I'll review later today. |
|
The following commit authors need to sign the Contributor License Agreement: |
Contributor
| - name: Push commit | ||
| uses: ad-m/github-push-action@881a6320fdb16eb5318c5054f31c218aec2b324c # v1.3.0 | ||
| if: env.SIGNIFICANT_CHANGES | ||
| if: env.SIGNIFICANT_CHANGES && (github.event.workflow_run.head_branch == github.event.repository.default_branch) |
Member
There was a problem hiding this comment.
There's no workflow_run trigger?
Co-authored-by: Stan Ulbrych <stanulbrych@gmail.com>
Collaborator
Author
|
@copilot resolve the merge conflicts in this pull request |
Contributor
StanFromIreland
approved these changes
Jun 26, 2026
Co-authored-by: Stan Ulbrych <stanulbrych@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By splitting workflows we get a better, gradual feedback and state of things expression.
Building without strict mode, we can add back strict mode as a separate workflow (or as part of linting?) in the future.
Updated READMEs with new workflow links. Extra changes: dropped translations mailing list and added a link to Sphinx translation.
Unable to test workflow run trigger before the PR is merged into main.
To do:
-Wflag); corresponding job called withmake dist-pdfdoesn't fail: https://github.com/m-aciek/python-docs-offline/actions/runs/27127952047/job/80061499030