Skip to content

Comments

Move NEWS entries to pull-request-lifecycle#1506

Merged
hugovk merged 11 commits intopython:mainfrom
StanFromIreland:move-news
Feb 21, 2026
Merged

Move NEWS entries to pull-request-lifecycle#1506
hugovk merged 11 commits intopython:mainfrom
StanFromIreland:move-news

Conversation

@StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Feb 3, 2025

@StanFromIreland
Copy link
Member Author

StanFromIreland commented Feb 3, 2025

@StanFromIreland
Copy link
Member Author

See also would be nice but it seems to make the section quoted.

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also would be nice but it seems to make the section quoted.

How do you mean?

StanFromIreland and others added 2 commits February 3, 2025 20:48
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@StanFromIreland
Copy link
Member Author

image

I must have done something weird before it works when I tried again!

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

StanFromIreland and others added 2 commits March 13, 2025 15:33
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@StanFromIreland StanFromIreland requested a review from picnixz March 13, 2025 15:38
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We improved a bit the content, but not by much, so it's fine to make it part of this change. I think we need a follow-up PR to improve the cases where a NEWS entry is necessary (see python/cpython#131177 (comment)). OTOH, you can revert the 3.X.rst mention and make it part of the follow-up PR.

Before merging, I'll check that the rst:role is correctly linked though.

@picnixz
Copy link
Member

picnixz commented Mar 13, 2025

Arf, it appears that we don't have the cross-referencing:

image

Well, let's introduce intersphinx in a future PR.

# Conflicts:
#	core-team/committing.rst
@StanFromIreland
Copy link
Member Author

Closed the originally linked issue as a duplicate of #674

# Conflicts:
#	core-team/committing.rst
@read-the-docs-community
Copy link

Documentation build overview

📚 CPython devguide | 🛠️ Build #31500147 | 📁 Comparing 95d1cd0 against latest (b736a43)


🔍 Preview build

Show files changed (13 files in total): 📝 13 modified | ➕ 0 added | ➖ 0 deleted
File Status
index.html 📝 modified
contrib/index.html 📝 modified
core-team/index.html 📝 modified
getting-started/index.html 📝 modified
versions/index.html 📝 modified
contrib/core-team/index.html 📝 modified
core-team/committing/index.html 📝 modified
getting-started/pull-request-lifecycle/index.html 📝 modified
triage/labels/index.html 📝 modified
triage/triaging/index.html 📝 modified
contrib/core-team/committing/index.html 📝 modified
contrib/triage/labels/index.html 📝 modified
contrib/triage/triaging/index.html 📝 modified

@hugovk hugovk merged commit 0fe9ca7 into python:main Feb 21, 2026
5 checks passed
@hugovk
Copy link
Member

hugovk commented Feb 21, 2026

Sorry, looks like we forgot about this one! Thanks again!

@StanFromIreland StanFromIreland deleted the move-news branch February 21, 2026 15:15
@StanFromIreland
Copy link
Member Author

Better late than never, thanks Hugo:-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sect. 3 (Lifecycle of a Pull Request) does not mention Misc/NEWS.d/next and blurb

3 participants