gh-151769: Fix IPv6Address ordering to account for scope_id#151864
Open
factnn wants to merge 1 commit into
Open
gh-151769: Fix IPv6Address ordering to account for scope_id#151864factnn wants to merge 1 commit into
factnn wants to merge 1 commit into
Conversation
factnn
force-pushed
the
fix/ipv6-ordering-scope-id
branch
from
74e1d05 to
5540a9e
Compare
factnn
force-pushed
the
fix/ipv6-ordering-scope-id
branch
from
5540a9e to
7f9d2f4
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #151769
IPv6Address.eq compares scope_id but lt (inherited from
_BaseAddress) only compared the integer address, breaking trichotomy
and making sorted() non-deterministic for addresses with the same
IP but different scope IDs.
Add lt to IPv6Address that compares by _ip first, then by
_scope_id (None sorts before any string).