gh-74667: Make socket.getservbyname(), getservbyport() and getprotobyname() thread-safe#151850
Open
tonghuaroot wants to merge 2 commits into
Open
gh-74667: Make socket.getservbyname(), getservbyport() and getprotobyname() thread-safe#151850tonghuaroot wants to merge 2 commits into
tonghuaroot wants to merge 2 commits into
Conversation
…rotobyname() thread-safe
…mment and test diagnostics
tonghuaroot
requested review from
AA-Turner,
corona10,
emmatyping,
erlend-aasland and
itamaro
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
socket.getservbyname(),getservbyport()andgetprotobyname()release the GIL around the non-reentrant POSIXgetservbyname(3)/getservbyport(3)/getprotobyname(3), which return a pointer into a shared static buffer, so concurrent calls (including on free-threading builds) can clobber each other's result.This uses the reentrant
*_r()variants whereconfiguredetects them, and otherwise serializes the lookups with the existingnetdb_lock, mirroring howgethostbyname()is already handled in the same module. A regression test exercises concurrent lookups.