gh-151042: venv: Pass VIRTUAL_ENV through cygpath inside fish on Windows#151043
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
43977d2 to
afb462e
Compare
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
9ac5922 to
0694664
Compare
|
@vsajip @FFY00 the equivalent PR was merged in both uv and virtualenv if you would like to compare for review :) |
|
This patch and the whereas the Isn't the more stringent check needed? Under |
@vsajip, it's not necessary. MSYS2 ships the Cygwin tool cygpath by default. MinGW as an environment requires MSYS2 to be installed. The codebase also uses cygpath unguarded at several points thus indicating that it is a requirement. It's fine to add a guard clause as the uv devs requested, I don't see how it could hurt, but its also not required. |
gh-151042: Fixed venv exporting mixed path styles to PATH on Windows inside fish (via Cygwin, MinGW or MSYS2)
This PR mirrors the changes from gh-103325, gh-125399 and gh-112508 to the fish activation script.