gh-75723: Fix double evaluation of .pth and .site files in venvs#149583
Open
warsaw wants to merge 14 commits intopython:mainfrom
Open
gh-75723: Fix double evaluation of .pth and .site files in venvs#149583warsaw wants to merge 14 commits intopython:mainfrom
warsaw wants to merge 14 commits intopython:mainfrom
Conversation
Based on @asottle branch !asottle-pythongh-75723 but refactored for `main`. This will need a different backport.
The original fix is here: python#147951 but I'm refactoring a bit for `main`.
warsaw
requested review from
AA-Turner,
ezio-melotti,
hugovk and
webknjaz
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a more comprehensive fix for Python 3.15 for #75723 reported by @asottile (thanks!). This should not be backported since it's specific to the additions made for PEP 829. I'll evaluate and update !147951 for 3.13 and 3.14 separately.
Huge thanks to @asottile for finding, reporting, and fixing the original bug.