gh-149567: Remove deprecated shutil.ExecError#149568
Open
StanFromIreland wants to merge 3 commits intopython:mainfrom
Open
gh-149567: Remove deprecated shutil.ExecError#149568StanFromIreland wants to merge 3 commits intopython:mainfrom
shutil.ExecError#149568StanFromIreland wants to merge 3 commits intopython:mainfrom
Conversation
StanFromIreland
commented
May 8, 2026
| self.x | ||
| from shutil import ExecError | ||
| print(ExecError) | ||
| from heapq import heapify_max |
Member
Author
There was a problem hiding this comment.
Turns out it was used somewhere after all! Technically this doesn't matter, but to avoid any potential confusion I changed it to something else.
I confirmed it still fails when 1561385 is reverted.
Documentation build overview
|
ZeroIntensity
approved these changes
May 9, 2026
Member
ZeroIntensity
left a comment
ZeroIntensity
left a comment
There was a problem hiding this comment.
LGTM. I believe #123125 was one of my earliest contributions, actually.
Just a heads-up: there are still some people using this. (See the search I referred to in the original deprecation issue.) I'm not super worried about it, considering we were emitting a warning, but it's definitely worth noting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shutil.ExecError#149567