Clarify docs for error case of PyDict_GetItemRef#149506
Open
ngoldbaum wants to merge 2 commits intopython:mainfrom
Open
Clarify docs for error case of PyDict_GetItemRef#149506ngoldbaum wants to merge 2 commits intopython:mainfrom
ngoldbaum wants to merge 2 commits intopython:mainfrom
Conversation
ngoldbaum
added
docs
ngoldbaum
force-pushed
the
fix-dict-getitemref-error-docs
branch
from
e873771 to
de69c83
Compare
Documentation build overview
|
ngoldbaum
force-pushed
the
fix-dict-getitemref-error-docs
branch
from
de69c83 to
2abbc1e
Compare
ngoldbaum
commented
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I manually inspected and asked Claude to inspect the implementation, and I think all error paths set
*resultto NULL.See numpy/numpy#31256 (comment) for where this came up for me today.