GH-144679: When building with VS2026 on Windows, use PlatformToolSet v145 by default #144680
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Furthermore, do not warn anymore when building with v145
chris-eibl
commented
Feb 10, 2026
| </ItemGroup> | ||
| </Target> | ||
| <Target Name="_WarnAboutToolset" BeforeTargets="PrepareForBuild" Condition="$(PlatformToolset) != 'v141' and $(PlatformToolset) != 'v142' and $(PlatformToolset) != 'v143'"> | ||
| <Target Name="_WarnAboutToolset" BeforeTargets="PrepareForBuild" Condition="$(PlatformToolset) != 'v141' and $(PlatformToolset) != 'v142' and $(PlatformToolset) != 'v143' and $(PlatformToolset) != 'v145'"> |
Member
Author
There was a problem hiding this comment.
On main, shall we warn for older toolsets like v141 or v142 now?
Likewise, shall we keep a warning for v145 on 3.13 / 3.14?
Contributor
There was a problem hiding this comment.
The minimum VS version for building Python now is 2017.
https://docs.python.org/3.15/using/configure.html
I removed the support for 2015 a year ago #124103 . However, according to the Mainstream End Date of the VS lifecycle, currently only VS2022 is still supported
https://learn.microsoft.com/lifecycle/products/visual-studio-2019
Member
There was a problem hiding this comment.
Yeah, let's start warning for those older ones.
zooba
approved these changes
Feb 11, 2026
Member
zooba
left a comment
zooba
left a comment
There was a problem hiding this comment.
Approved with change in comments (ping me if nobody else merges)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Furthermore do not warn when PlatformToolSet v145 is used.