Skip to content

gh-132132: Upgrade to VS 2026 on Windows tailcall CI#144544

Merged
Fidget-Spinner merged 1 commit intopython:mainfrom
Fidget-Spinner:tailcall-windows-ci
Feb 6, 2026
Merged

gh-132132: Upgrade to VS 2026 on Windows tailcall CI#144544
Fidget-Spinner merged 1 commit intopython:mainfrom
Fidget-Spinner:tailcall-windows-ci

Conversation

@Fidget-Spinner
Copy link
Member

@Fidget-Spinner Fidget-Spinner commented Feb 6, 2026

Copy link
Member

@chris-eibl chris-eibl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked in the CI output that VS2026 with PlatformToolset="v145" was used for compiling 🚀

Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI changes seem fine. Skipping the test is something someone else should be confirming.

@chris-eibl
Copy link
Member

chris-eibl commented Feb 6, 2026

Skipping the dtrace tests on Windows is fine. They've never been run before on Windows and are now just "picked up", because dtrace is now part of Windows Server 2025. See #138744 (comment) and #144516 (comment):

test_dtrace can be skipped on Windows, yes.

@Fidget-Spinner Fidget-Spinner merged commit 25e99b3 into python:main Feb 6, 2026
59 checks passed
@github-project-automation github-project-automation bot moved this from 🧐 @webknjaz's review queue 📋 to 🌈 Done 🦄 in 📅 Procrastinating in public 😵‍💫 Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants