Skip to content

gh-139109: Replace _CHECK_STACK_SPACE with _CHECK_STACK_SPACE_OPERAND in JIT optiimizer #144394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
markshannon merged 3 commits into from
Feb 2, 2026
Merged

gh-139109: Replace _CHECK_STACK_SPACE with _CHECK_STACK_SPACE_OPERAND in JIT optiimizer #144394

markshannon merged 3 commits into from
Feb 2, 2026
+44 −64

Conversation

@cocolato
Copy link
Contributor

@cocolato cocolato commented Feb 2, 2026 •
edited by bedevere-app bot
Loading

Refer: #144388
This implements a simple one-to-one replacement of _CHECK_STACK_SPACE with _CHECK_STACK_SPACE_OPERAND in the JIT optimizer.
Also open and rewrite all the tests that are disabled in #139109.

@bedevere-app bedevere-app bot mentioned this pull request Feb 2, 2026
Open
cocolato
cocolato commented Feb 2, 2026
View reviewed changes
markshannon
markshannon requested changes Feb 2, 2026
View reviewed changes
Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good generally.
I suspect that using ADD_OP and REPLACE_OP together may be broken, but that won't matter if we make _CHECK_STACK_SPACE_OPERAND only check stack space.

@bedevere-app
Copy link

bedevere-app bot commented Feb 2, 2026

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@cocolato
Copy link
Contributor Author

cocolato commented Feb 2, 2026

I have made the requested changes; please review again

@bedevere-app
Copy link

bedevere-app bot commented Feb 2, 2026

Thanks for making the requested changes!

@markshannon: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from markshannon February 2, 2026 16:23
markshannon
markshannon approved these changes Feb 2, 2026
View reviewed changes
Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now, thanks.

@markshannon markshannon merged commit 89e6607 into python:main Feb 2, 2026
74 of 77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon markshannon approved these changes

@tomasr8 tomasr8 Awaiting requested review from tomasr8 tomasr8 is a code owner

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner Fidget-Spinner is a code owner

@savannahostrowski savannahostrowski Awaiting requested review from savannahostrowski savannahostrowski is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cocolato @markshannon